Skip to content

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 10, 2025

Since the start of the project (efabb47), we have used the welcome bot to greet first-time contributors when they open an issue or submit a pull request. It has worked well, but the welcome bot has been unmaintained for five years.

This PR replaces it with the actions/first-interaction workflow, which is actively maintained and likely more lightweight — the welcome bot is a Probot app, whereas actions/first-interaction runs as a GitHub Action.

One limitation of actions/first-interaction is that it cannot comment when a pull request is merged. For now, I’ve combined the newPRWelcomeComment and firstPRMergeComment messages into pr_message. We may implement the firstPRMergeComment functionality using gh pr comment triggered by a PR merge event. Edit: I don't think it's possible, since we can't know if a PR is someone's first PR.

I've tested the welcome workflow in my own fork. It works well, with a welcome comment at seisman#2 (the format of the message is fixed in 1bbfde2) and no comment at seisman#3.

TODO

  • Initial implemention
  • Decide if we want to implement the firstPRMergeComment functionality in this PR
  • Improve the welcome messages
  • Make the same changes to the GMT repository CI: Migrate the welcome bot to GitHub Actions gmt#8814
  • Uninstall the welcome bot App from the GMT org

@seisman seisman added the maintenance Boring but important stuff for the core devs label Oct 10, 2025
@seisman seisman added this to the 0.18.0 milestone Oct 10, 2025
@seisman seisman added the needs review This PR has higher priority and needs review. label Oct 10, 2025
@seisman seisman requested a review from a team October 14, 2025 13:35
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think it's ok to leave out the first PR merge comment as we can thank people manually, not everything needs to be automated 😉

@weiji14 weiji14 merged commit ce57041 into GenericMappingTools:main Oct 14, 2025
5 checks passed
@weiji14 weiji14 removed the needs review This PR has higher priority and needs review. label Oct 14, 2025
@seisman seisman deleted the ci/welcome branch October 14, 2025 23:25
@weiji14
Copy link
Member

weiji14 commented Oct 21, 2025

Confirmed that it works - #4170 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants